From: Jes Sorensen <Jes.Sorensen@redhat.com>
Date: Mon, 7 Mar 2016 18:53:43 +0000 (-0500)
Subject: Manage: Manage_subdevs() fix file descriptor leak
X-Git-Tag: mdadm-4.0~118
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cc5083d114c4c88bc9477c2773b4b2426c4621e7;p=thirdparty%2Fmdadm.git

Manage: Manage_subdevs() fix file descriptor leak

Reviewed-by: NeilBrown <neilb@suse.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---

diff --git a/Manage.c b/Manage.c
index a812ba05..ab4ac09f 100644
--- a/Manage.c
+++ b/Manage.c
@@ -1508,9 +1508,10 @@ int Manage_subdevs(char *devname, int fd,
 		} else {
 			struct stat stb;
 			tfd = dev_open(dv->devname, O_RDONLY);
-			if (tfd >= 0)
+			if (tfd >= 0) {
 				fstat(tfd, &stb);
-			else {
+				close(tfd);
+			} else {
 				int open_err = errno;
 				if (stat(dv->devname, &stb) != 0) {
 					pr_err("Cannot find %s: %s\n",