From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Thu, 2 May 2019 15:41:48 +0000 (-0600)
Subject: Tune "rename boolean column w CHECK constraint" test for MySQL 8, mariadb10.2
X-Git-Tag: rel_1_0_11~19
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cc82fac22f0c121f83bb3b47f216443fe1ed8541;p=thirdparty%2Fsqlalchemy%2Falembic.git

Tune "rename boolean column w CHECK constraint" test for MySQL 8, mariadb10.2

Change-Id: Idb5292f3976b9632069145ff0a7df948a945d7d8
Fixes: #556
---

diff --git a/tests/requirements.py b/tests/requirements.py
index 3fb949fc..02b84f77 100644
--- a/tests/requirements.py
+++ b/tests/requirements.py
@@ -179,7 +179,23 @@ class DefaultRequirements(SuiteRequirements):
             > (10, 2)
         )
 
-    def _mariadb_only_102(self, config):
+    def mysql_check_col_name_change(self, config):
+        if exclusions.against(config, "mysql"):
+            if sqla_compat._is_mariadb(config.db.dialect):
+                mnvi = sqla_compat._mariadb_normalized_version_info
+                norm_version_info = mnvi(config.db.dialect)
+                return norm_version_info >= (10, 2) and norm_version_info < (
+                    10,
+                    2,
+                    22,
+                )
+            else:
+                norm_version_info = config.db.dialect.server_version_info
+                return norm_version_info >= (8, 0, 16)
+
+        else:
+            return False
+
         return (
             exclusions.against(config, "mysql")
             and sqla_compat._is_mariadb(config.db.dialect)
diff --git a/tests/test_batch.py b/tests/test_batch.py
index aa998539..8879c9ca 100644
--- a/tests/test_batch.py
+++ b/tests/test_batch.py
@@ -1638,7 +1638,7 @@ class BatchRoundTripMySQLTest(BatchRoundTripTest):
         super(BatchRoundTripMySQLTest, self).test_create_drop_index()
 
     # fails on mariadb 10.2, succeeds on 10.3
-    @exclusions.fails_if(config.requirements._mariadb_only_102)
+    @exclusions.fails_if(config.requirements.mysql_check_col_name_change)
     def test_rename_column_boolean(self):
         super(BatchRoundTripMySQLTest, self).test_rename_column_boolean()