From: William Lallemand <wlallemand@haproxy.com>
Date: Thu, 8 Jun 2017 17:30:39 +0000 (+0200)
Subject: BUG/MINOR: warning: ‘need_resend’ may be used uninitialized
X-Git-Tag: v1.8-dev3~301
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cc9b94ac943caaa0292ca047a63f64a382d85d80;p=thirdparty%2Fhaproxy.git

BUG/MINOR: warning: ‘need_resend’ may be used uninitialized

The commit 201c07f68 ("MAJOR/REORG: dns: DNS resolution task and
requester queues") introduces a warning during compilation:

src/dns.c: In function ‘dns_resolve_recv’:
src/dns.c:487:6: warning: ‘need_resend’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   if (need_resend) {
      ^

This patch initialize the variable and remove the comment about it.
---

diff --git a/src/dns.c b/src/dns.c
index cb7de6ab67..78ee62bcc8 100644
--- a/src/dns.c
+++ b/src/dns.c
@@ -322,7 +322,7 @@ void dns_resolve_recv(struct dgram_conn *dgram)
 	struct dns_query_item *query;
 	unsigned char buf[DNS_MAX_UDP_MESSAGE + 1];
 	unsigned char *bufend;
-	int fd, buflen, dns_resp, need_resend;
+	int fd, buflen, dns_resp, need_resend = 0;
 	unsigned short query_id;
 	struct eb32_node *eb;
 	struct lru64 *lru = NULL;
@@ -387,12 +387,6 @@ void dns_resolve_recv(struct dgram_conn *dgram)
 
 		dns_resp = dns_validate_dns_response(buf, bufend, resolution);
 
-		/* treat errors first
-		 * need_resend flag could be set to 0 by default before the 'switch' and then
-		 * set to 1 only where needed, but I think it's better this way to make people
-		 * aware they have to think twice how to set this flag when updating this portion
-		 * of the code
-		 */
 		switch (dns_resp) {
 			case DNS_RESP_VALID:
 				need_resend = 0;