From: Mark Wielaard <mark@klomp.org>
Date: Fri, 4 Sep 2015 10:52:01 +0000 (+0000)
Subject: Bug #352130 helgrind reports false races for printfs using mempcpy
X-Git-Tag: svn/VALGRIND_3_11_0~35
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cc9d412d2d96c32e949db46f0ed7b6a110b5d973;p=thirdparty%2Fvalgrind.git

Bug #352130 helgrind reports false races for printfs using mempcpy

Add a new Race suppression.

git-svn-id: svn://svn.valgrind.org/valgrind/trunk@15622
---

diff --git a/NEWS b/NEWS
index a03b403b7f..fd35e212a5 100644
--- a/NEWS
+++ b/NEWS
@@ -371,6 +371,7 @@ where XXXXXX is the bug number as listed below.
 351756  Intercept platform_memchr$VARIANT$Haswell on OS X
 351858  ldsoexec support on Solaris
 351873  Newer gcc doesn't allow __builtin_tabortdc[i] in ppc32 mode
+352130  helgrind reports false races for printfs using mempcpy on FILE* state
 n-i-bz  Provide implementations of certain compiler builtins to support
         compilers that may not provide those
 n-i-bz  Old STABS code is still being compiled, but never used. Remove it.
diff --git a/glibc-2.34567-NPTL-helgrind.supp b/glibc-2.34567-NPTL-helgrind.supp
index b61a339556..ed105b8db6 100644
--- a/glibc-2.34567-NPTL-helgrind.supp
+++ b/glibc-2.34567-NPTL-helgrind.supp
@@ -23,6 +23,10 @@
 #   this, then loads of errors to do with stdio are reported, because
 #   H fails to see glibc's internal locking/unlocking of FILE*s
 #   as required by POSIX.  A better solution is needed.
+#
+# - some of the stdio functions in newer glibc manipulate stdio
+#   FILE*s state through mempcpy, which we intercept, so we also need
+#   to suppress such manipulations.
 
 #{
 #   helgrind-glibc2X-001
@@ -40,6 +44,14 @@
    obj:*/lib*/libc-2.*so*
 }
 
+{
+   helgrind-glibc-io-xsputn-mempcpy
+   Helgrind:Race
+   fun:__GI_mempcpy
+   fun:_IO_*xsputn*
+   obj:*/lib*/libc-2.*so*
+}
+
 {
    helgrind-glibc2X-005
    Helgrind:Race