From: Will Newton <will.newton@linaro.org>
Date: Fri, 16 Aug 2013 11:54:29 +0000 (+0100)
Subject: malloc: Check for integer overflow in memalign.
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ccb8f6bab96cfcc7aedf5cd0d1946f26b028d733;p=thirdparty%2Fglibc.git

malloc: Check for integer overflow in memalign.

A large bytes parameter to memalign could cause an integer overflow
and corrupt allocator internals. Check the overflow does not occur
before continuing with the allocation.

ChangeLog:

2013-09-11  Will Newton  <will.newton@linaro.org>

	[BZ #15857]
	* malloc/malloc.c (__libc_memalign): Check the value of bytes
	does not overflow.
---

diff --git a/ChangeLog b/ChangeLog
index bd8deafc6ca..1669b71cad3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2013-09-11  Will Newton  <will.newton@linaro.org>
+
+	[BZ #15857]
+	* malloc/malloc.c (__libc_memalign): Check the value of bytes
+	does not overflow.
+
 2013-09-11  Will Newton  <will.newton@linaro.org>
 
 	[BZ #15856]
diff --git a/malloc/malloc.c b/malloc/malloc.c
index d5dacbf5bc3..d04cae8f70b 100644
--- a/malloc/malloc.c
+++ b/malloc/malloc.c
@@ -3030,6 +3030,13 @@ __libc_memalign(size_t alignment, size_t bytes)
   /* Otherwise, ensure that it is at least a minimum chunk size */
   if (alignment <  MINSIZE) alignment = MINSIZE;
 
+  /* Check for overflow.  */
+  if (bytes > SIZE_MAX - alignment - MINSIZE)
+    {
+      __set_errno (ENOMEM);
+      return 0;
+    }
+
   arena_get(ar_ptr, bytes + alignment + MINSIZE);
   if(!ar_ptr)
     return 0;