From: Alan T. DeKok <aland@freeradius.org>
Date: Fri, 26 Jan 2024 22:11:58 +0000 (-0500)
Subject: VP isn't used
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cd0dd9e16460dee6dbd37ebeecadf1a3be8cbf31;p=thirdparty%2Ffreeradius-server.git

VP isn't used
---

diff --git a/src/protocols/dhcpv4/encode.c b/src/protocols/dhcpv4/encode.c
index faca5d70808..06defb4769c 100644
--- a/src/protocols/dhcpv4/encode.c
+++ b/src/protocols/dhcpv4/encode.c
@@ -759,7 +759,6 @@ ssize_t fr_dhcpv4_encode_option(fr_dbuff_t *dbuff, fr_dcursor_t *cursor, void *e
 ssize_t	fr_dhcpv4_encode_foreign(fr_dbuff_t *dbuff, fr_pair_list_t const *list)
 {
 	ssize_t		slen;
-	fr_pair_t	*vp;
 	fr_dcursor_t	cursor;
 	fr_dbuff_t	work_dbuff = FR_DBUFF(dbuff);
 
@@ -773,7 +772,7 @@ ssize_t	fr_dhcpv4_encode_foreign(fr_dbuff_t *dbuff, fr_pair_list_t const *list)
 	 *	Unlike fr_dhcpv4_encode_dbuff(), we don't sort the options.  If that causes problems, we will
 	 *	deal with it later.
 	 */
-	while ((vp = fr_dcursor_current(&cursor))) {
+	while (fr_dcursor_current(&cursor) != NULL) {
 		slen = fr_dhcpv4_encode_option(&work_dbuff, &cursor, &(fr_dhcpv4_ctx_t){ .root = fr_dict_root(dict_dhcpv4) });
 		if (slen <= 0) return slen - fr_dbuff_used(&work_dbuff);
 	}