From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Fri, 15 Jun 2018 09:52:04 +0000 (+0200)
Subject: coverity: #1425818
X-Git-Tag: lxc-2.0.10~81
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cd1cbee0c32639c8c2df091f60477295977deefb;p=thirdparty%2Flxc.git

coverity: #1425818

Dereference after null check

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/start.c b/src/lxc/start.c
index 7991bb0e1..b5c22e164 100644
--- a/src/lxc/start.c
+++ b/src/lxc/start.c
@@ -741,11 +741,9 @@ int lxc_init(const char *name, struct lxc_handler *handler)
 	TRACE("set container state to \"STARTING\"");
 
 	/* Start of environment variable setup for hooks. */
-	if (name) {
-		ret = setenv("LXC_NAME", name, 1);
-		if (ret < 0)
-			SYSERROR("Failed to set environment variable: LXC_NAME=%s", name);
-	}
+	ret = setenv("LXC_NAME", name, 1);
+	if (ret < 0)
+		SYSERROR("Failed to set environment variable: LXC_NAME=%s", name);
 
 	if (conf->rcfile) {
 		ret = setenv("LXC_CONFIG_FILE", conf->rcfile, 1);