From: Laine Stump <laine@redhat.com>
Date: Sun, 13 Mar 2022 18:21:02 +0000 (-0400)
Subject: util: replace g_snprintf with g_autofreed g_strdup_printf in viriptables.c
X-Git-Tag: v8.7.0-rc1~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cd23bf182ca752974316ae0697195eddd525f7df;p=thirdparty%2Flibvirt.git

util: replace g_snprintf with g_autofreed g_strdup_printf in viriptables.c

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/util/viriptables.c b/src/util/viriptables.c
index e9886a200e..6275760de4 100644
--- a/src/util/viriptables.c
+++ b/src/util/viriptables.c
@@ -163,10 +163,7 @@ iptablesInput(virFirewall *fw,
               int action,
               int tcp)
 {
-    char portstr[32];
-
-    g_snprintf(portstr, sizeof(portstr), "%d", port);
-    portstr[sizeof(portstr) - 1] = '\0';
+    g_autofree char *portstr = g_strdup_printf("%d", port);
 
     virFirewallAddRule(fw, layer,
                        "--table", "filter",
@@ -187,10 +184,7 @@ iptablesOutput(virFirewall *fw,
                int action,
                int tcp)
 {
-    char portstr[32];
-
-    g_snprintf(portstr, sizeof(portstr), "%d", port);
-    portstr[sizeof(portstr) - 1] = '\0';
+    g_autofree char *portstr = g_strdup_printf("%d", port);
 
     virFirewallAddRule(fw, layer,
                        "--table", "filter",
@@ -1028,10 +1022,7 @@ iptablesOutputFixUdpChecksum(virFirewall *fw,
                              int port,
                              int action)
 {
-    char portstr[32];
-
-    g_snprintf(portstr, sizeof(portstr), "%d", port);
-    portstr[sizeof(portstr) - 1] = '\0';
+    g_autofree char *portstr = g_strdup_printf("%d", port);
 
     virFirewallAddRule(fw, VIR_FIREWALL_LAYER_IPV4,
                        "--table", "mangle",