From: Alan T. DeKok <aland@freeradius.org>
Date: Fri, 21 Nov 2025 21:37:51 +0000 (-0500)
Subject: the new child is always parented by the new dst DA
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cd32fa69bca90adce5723975c8ef28fe812f5ef5;p=thirdparty%2Ffreeradius-server.git

the new child is always parented by the new dst DA

otherwise the child is marked up as having the old parent, which
is wrong.
---

diff --git a/src/lib/util/dict_util.c b/src/lib/util/dict_util.c
index dc5c4136a08..c453fa74867 100644
--- a/src/lib/util/dict_util.c
+++ b/src/lib/util/dict_util.c
@@ -1175,11 +1175,7 @@ static int dict_attr_acopy_child(fr_dict_t *dict, fr_dict_attr_t *dst, fr_dict_a
 {
 	fr_dict_attr_t			*copy;
 
-	if (child->dict == dict) {
-		copy = dict_attr_acopy(dict->pool, child, NULL);
-	} else {
-		copy = dict_attr_acopy_dict(dict->pool, dst, child);
-	}
+	copy = dict_attr_acopy_dict(dict->pool, dst, child);
 	if (!copy) return -1;
 
 	fr_assert(copy->parent == dst);