From: Kruti Pendharkar <kp025370@broadcom.com>
Date: Tue, 25 Feb 2025 09:29:11 +0000 (-0800)
Subject: Fix the assembler warning
X-Git-Tag: stable-13.0.0~16
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cd4c71ad389406ad5d20d5de66aabaea13ab610f;p=thirdparty%2Fopen-vm-tools.git

Fix the assembler warning

The Warning "found movsd; assuming movsl was meant" was noticed while
building open-vm-tools with gcc 12.2.0 (on Debian 12.2.0-14).
It was because of the change https://sourceware.org/bugzilla/show_bug.cgi?id=29525
made to the GNU assembler code (GNU Binutils for Debian) 2.39.90.20221231.

Replace the instruction "movsd" with "movsl" to avoid this warning.
---

diff --git a/open-vm-tools/lib/misc/utilMem.c b/open-vm-tools/lib/misc/utilMem.c
index 56846fe73..307c6edfb 100644
--- a/open-vm-tools/lib/misc/utilMem.c
+++ b/open-vm-tools/lib/misc/utilMem.c
@@ -1,5 +1,6 @@
 /*********************************************************
- * Copyright (C) 2009-2019 VMware, Inc. All rights reserved.
+ * Copyright (c) 2009-2025 Broadcom. All Rights Reserved.
+ * The term "Broadcom" refers to Broadcom Inc. and/or its subsidiaries.
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms of the GNU Lesser General Public License as published
@@ -431,7 +432,7 @@ Util_Memcpy(void *dest,      // OUT:
       } else if ((align & 3) == 0) {
          __asm__ __volatile__("\t"
                                "cld"            "\n\t"
-                               "rep ; movsd"    "\n"
+                               "rep ; movsl"    "\n"
                                : "=c" (dummy0), "=D" (dummy1), "=S" (dummy2)
                                : "0" (count >> 2), "1" (dest), "2" (src)
                                : "memory", "cc"