From: Harlan Stenn <stenn@ntp.org>
Date: Sat, 5 Dec 2015 10:41:51 +0000 (+0000)
Subject: CID 1341677: Nits in sntp/tests/keyFile.c.  HStenn.
X-Git-Tag: NTP_4_3_87~1^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cd611c5ceaefa52305a71a8125eb7c7bc8badf30;p=thirdparty%2Fntp.git

CID 1341677: Nits in sntp/tests/keyFile.c.  HStenn.

bk: 5662bf6fYtZe7PAeiJoxB5TE6gLesQ
---

diff --git a/ChangeLog b/ChangeLog
index d4b267de7..b4a8ab765 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -10,6 +10,7 @@
 * CID 1341536: Resource leak in tests/ntpd/t-ntp_signd.c.  HStenn.
 * CID 1341537: Resource leak in tests/ntpd/t-ntp_signd.c.  HStenn.
 * CID 1341538: Memory leak in tests/ntpd/ntp_prio_q.c:262.  HStenn.
+* CID 1341677: Nits in sntp/tests/keyFile.c.  HStenn.
 * CID 1341678: Nits in sntp/tests/keyFile.c.  HStenn.
 * CID 1341679: Nits in sntp/tests/keyFile.c.  HStenn.
 * CID 1341680: Nits in sntp/tests/keyFile.c.  HStenn.
diff --git a/sntp/tests/keyFile.c b/sntp/tests/keyFile.c
index c9b1ef0df..883658a2b 100644
--- a/sntp/tests/keyFile.c
+++ b/sntp/tests/keyFile.c
@@ -75,11 +75,14 @@ test_ReadEmptyKeyFile(void) {
 void
 test_ReadASCIIKeys(void) {
 	struct key* keys = NULL;
+	const char *path = CreatePath("key-test-ascii", INPUT_DIR);
 
-	TEST_ASSERT_EQUAL(2, auth_init(CreatePath("key-test-ascii", INPUT_DIR), &keys));
-
+	TEST_ASSERT_NOT_NULL(path);
+	TEST_ASSERT_EQUAL(2, auth_init(path, &keys));
 	TEST_ASSERT_NOT_NULL(keys);
 
+	free((void *)path);
+
 	struct key* result = NULL;
 	get_key(40, &result);
 	TEST_ASSERT_NOT_NULL(result);