From: Jim Meyering <meyering@redhat.com>
Date: Mon, 3 Mar 2008 13:16:31 +0000 (+0000)
Subject: Plug skipped-qemudCleanup leak.
X-Git-Tag: LIBVIRT_0_4_1~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cd6eefd3e887c6a0209f1cdbc1c4d6e5ca69aa76;p=thirdparty%2Flibvirt.git

Plug skipped-qemudCleanup leak.

* qemud/qemud.c (main): Call qemudCleanup also upon failure.
Otherwise, an error return would skip it and induce leaks.
---

diff --git a/ChangeLog b/ChangeLog
index a73c34b67c..4a08b00b0d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 Mon Mar  3 14:14:03 CET 2008 Jim Meyering <meyering@redhat.com>
 
+	Plug skipped-qemudCleanup leak.
+	* qemud/qemud.c (main): Call qemudCleanup also upon failure.
+	Otherwise, an error return would skip it and induce leaks.
+
 	Plug remoteReadConfigFile leak.
 	* qemud/qemud.c (remoteReadConfigFile): Be careful to free
 	"conf" after a successful virConfReadFile.
diff --git a/qemud/qemud.c b/qemud/qemud.c
index 851e83ed70..7ccc9ee00b 100644
--- a/qemud/qemud.c
+++ b/qemud/qemud.c
@@ -2166,8 +2166,6 @@ int main(int argc, char **argv) {
 
     qemudRunLoop(server);
 
-    qemudCleanup(server);
-
     close(sigwrite);
 
     if (godaemon)
@@ -2181,6 +2179,7 @@ int main(int argc, char **argv) {
         unlink (pid_file);
 
  error1:
+    qemudCleanup(server);
     return ret;
 }