From: Paul Floyd <pjfloyd@wanadoo.fr>
Date: Fri, 3 Feb 2023 12:48:22 +0000 (+0100)
Subject: Regtest: foix warning from drd test pth_mutex_signal.c
X-Git-Tag: VALGRIND_3_21_0~180
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cdabd4ba74ea653515a1bf9a6e9067f3179c2d54;p=thirdparty%2Fvalgrind.git

Regtest: foix warning from drd test pth_mutex_signal.c

GCC on RHEL 7.6 ARM complains about the empty init list.

I also noticed that we are using the SA_NOTIFY form of sigaction
(with that union member and handler prototype) but not setting the
SA_NOTIFY flag. Seems harmless in this case as we don't use
the siginfo or context.
---

diff --git a/drd/tests/pth_mutex_signal.c b/drd/tests/pth_mutex_signal.c
index 38fafdba8a..916afdfe59 100644
--- a/drd/tests/pth_mutex_signal.c
+++ b/drd/tests/pth_mutex_signal.c
@@ -42,12 +42,12 @@ int main ()
   pthread_mutexattr_t mutex_attr;
   pthread_attr_t thread_attr_contender;
   pthread_t contender;
-  struct sigaction signalAction = { };
+  struct sigaction signalAction;
 
   // install signal handler
   signalAction.sa_sigaction = nullHandler;
   sigfillset(&signalAction.sa_mask);
-  signalAction.sa_flags = 0;
+  signalAction.sa_flags = SA_SIGINFO;
   sigaction(SIGINT, &signalAction, NULL);
 
   // initialize the mutex