From: Eric Blake <eblake@redhat.com>
Date: Wed, 29 Jun 2011 18:04:08 +0000 (-0600)
Subject: virsh: avoid uninitialized variable
X-Git-Tag: v0.9.3~27
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cdb0e0dc3fd2c217e6391ec134334b3dfe4410cc;p=thirdparty%2Flibvirt.git

virsh: avoid uninitialized variable

Detected by Coverity; neither vshCmddefHelp nor vshCmdOptParse
was initializing opts_required.

* tools/virsh.c (vshCmddefOptParse): Always initialize bitmaps.
---

diff --git a/tools/virsh.c b/tools/virsh.c
index f96ee040df..9a189fddbf 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -11915,12 +11915,15 @@ vshCmddefGetInfo(const vshCmdDef * cmd, const char *name)
 }
 
 static int
-vshCmddefOptParse(const vshCmdDef *cmd, uint32_t* opts_need_arg,
+vshCmddefOptParse(const vshCmdDef *cmd, uint32_t *opts_need_arg,
                   uint32_t *opts_required)
 {
     int i;
     bool optional = false;
 
+    *opts_need_arg = 0;
+    *opts_required = 0;
+
     if (!cmd->opts)
         return 0;