From: John Mulligan <jmulligan@redhat.com>
Date: Wed, 31 Jul 2024 19:36:26 +0000 (-0400)
Subject: ctdb-tests: add unit test coverage for listnodes with command
X-Git-Tag: tdb-1.4.12~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cdb5646b88589407720fef0ff7306fc6993018a3;p=thirdparty%2Fsamba.git

ctdb-tests: add unit test coverage for listnodes with command

Signed-off-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
---

diff --git a/ctdb/tests/UNIT/tool/ctdb.listnodes.003.sh b/ctdb/tests/UNIT/tool/ctdb.listnodes.003.sh
new file mode 100755
index 00000000000..95aae505aeb
--- /dev/null
+++ b/ctdb/tests/UNIT/tool/ctdb.listnodes.003.sh
@@ -0,0 +1,28 @@
+#!/bin/sh
+
+. "${TEST_SCRIPTS_DIR}/unit.sh"
+
+define_test "list nodes via command"
+
+cat > "${CTDB_BASE}/ctdb.conf" <<EOF
+[cluster]
+	nodes list = !${CTDB_BASE}/nodes.sh
+EOF
+test_cleanup rm -rf "${CTDB_BASE}/ctdb.conf"
+
+cat > "${CTDB_BASE}/nodes.sh" <<EOF
+#!/bin/sh
+for x in 41 42 43; do
+	echo 192.168.20.\$x
+done
+EOF
+test_cleanup rm -rf "${CTDB_BASE}/nodes.sh"
+chmod +x "${CTDB_BASE}/nodes.sh"
+
+required_result 0 <<EOF
+192.168.20.41
+192.168.20.42
+192.168.20.43
+EOF
+
+simple_test
diff --git a/ctdb/tests/UNIT/tool/ctdb.listnodes.004.sh b/ctdb/tests/UNIT/tool/ctdb.listnodes.004.sh
new file mode 100755
index 00000000000..ca8ef8e7c2b
--- /dev/null
+++ b/ctdb/tests/UNIT/tool/ctdb.listnodes.004.sh
@@ -0,0 +1,29 @@
+#!/bin/sh
+
+. "${TEST_SCRIPTS_DIR}/unit.sh"
+
+define_test "list nodes command fails"
+
+cat > "${CTDB_BASE}/ctdb.conf" <<EOF
+[cluster]
+	nodes list = !${CTDB_BASE}/nodes.sh
+EOF
+test_cleanup rm -rf "${CTDB_BASE}/ctdb.conf"
+
+cat > "${CTDB_BASE}/nodes.sh" <<EOF
+#!/bin/sh
+echo "error: foo" >&2
+exit 1
+EOF
+test_cleanup rm -rf "${CTDB_BASE}/nodes.sh"
+chmod +x "${CTDB_BASE}/nodes.sh"
+
+
+f="${CTDB_BASE}/nodes.sh"
+
+required_result 1 <<EOF
+error: foo
+${TEST_DATE_STAMP}Failed to read nodes from "!${f}"
+EOF
+
+simple_test
diff --git a/ctdb/tests/UNIT/tool/ctdb.listnodes.005.sh b/ctdb/tests/UNIT/tool/ctdb.listnodes.005.sh
new file mode 100755
index 00000000000..2d272618b57
--- /dev/null
+++ b/ctdb/tests/UNIT/tool/ctdb.listnodes.005.sh
@@ -0,0 +1,21 @@
+#!/bin/sh
+
+. "${TEST_SCRIPTS_DIR}/unit.sh"
+
+define_test "list nodes command invalid"
+
+cat > "${CTDB_BASE}/ctdb.conf" <<EOF
+[cluster]
+	nodes list = !${CTDB_BASE}/nodes.sh
+EOF
+test_cleanup rm -rf "${CTDB_BASE}/ctdb.conf"
+
+
+f="${CTDB_BASE}/nodes.sh"
+
+required_result 1 <<EOF
+sys_popenv: ERROR executing command '${f}': No such file or directory
+${TEST_DATE_STAMP}Failed to read nodes from "!${f}"
+EOF
+
+simple_test
diff --git a/ctdb/tests/UNIT/tool/ctdb.listnodes.006.sh b/ctdb/tests/UNIT/tool/ctdb.listnodes.006.sh
new file mode 100755
index 00000000000..cd95739af98
--- /dev/null
+++ b/ctdb/tests/UNIT/tool/ctdb.listnodes.006.sh
@@ -0,0 +1,32 @@
+#!/bin/sh
+
+. "${TEST_SCRIPTS_DIR}/unit.sh"
+
+define_test "list nodes command with bad output"
+
+cat > "${CTDB_BASE}/ctdb.conf" <<EOF
+[cluster]
+	nodes list = !${CTDB_BASE}/nodes.sh
+EOF
+test_cleanup rm -rf "${CTDB_BASE}/ctdb.conf"
+
+# ctdb certainly doesn't understand xml
+cat > "${CTDB_BASE}/nodes.sh" <<EOF
+#!/bin/sh
+echo "<nodes>"
+echo "<node id="0" name="192.168.20.41" />"
+echo "<node id="1" name="192.168.20.42" />"
+echo "</nodes>"
+EOF
+test_cleanup rm -rf "${CTDB_BASE}/nodes.sh"
+chmod +x "${CTDB_BASE}/nodes.sh"
+
+
+f="${CTDB_BASE}/nodes.sh"
+
+required_result 1 <<EOF
+Invalid node address <nodes>
+${TEST_DATE_STAMP}Failed to read nodes from "!${f}"
+EOF
+
+simple_test
diff --git a/ctdb/tests/UNIT/tool/ctdb.listnodes.007.sh b/ctdb/tests/UNIT/tool/ctdb.listnodes.007.sh
new file mode 100755
index 00000000000..37e2f10c38b
--- /dev/null
+++ b/ctdb/tests/UNIT/tool/ctdb.listnodes.007.sh
@@ -0,0 +1,32 @@
+#!/bin/sh
+
+. "${TEST_SCRIPTS_DIR}/unit.sh"
+
+define_test "list nodes command valid output, but script still fails"
+
+cat > "${CTDB_BASE}/ctdb.conf" <<EOF
+[cluster]
+	nodes list = !${CTDB_BASE}/nodes.sh
+EOF
+test_cleanup rm -rf "${CTDB_BASE}/ctdb.conf"
+
+cat > "${CTDB_BASE}/nodes.sh" <<EOF
+#!/bin/sh
+for x in 41 42 43; do
+	echo 192.168.20.\$x
+done
+exit 2
+EOF
+test_cleanup rm -rf "${CTDB_BASE}/nodes.sh"
+chmod +x "${CTDB_BASE}/nodes.sh"
+
+
+f="${CTDB_BASE}/nodes.sh"
+
+required_result 0 <<EOF
+192.168.20.41
+192.168.20.42
+192.168.20.43
+EOF
+
+simple_test
diff --git a/ctdb/tests/UNIT/tool/ctdb.listnodes.008.sh b/ctdb/tests/UNIT/tool/ctdb.listnodes.008.sh
new file mode 100755
index 00000000000..9453db4d9d7
--- /dev/null
+++ b/ctdb/tests/UNIT/tool/ctdb.listnodes.008.sh
@@ -0,0 +1,18 @@
+#!/bin/sh
+
+. "${TEST_SCRIPTS_DIR}/unit.sh"
+
+define_test "list nodes command with argument"
+
+cat > "${CTDB_BASE}/ctdb.conf" <<EOF
+[cluster]
+	nodes list = !/usr/bin/printf %s\\n%s\\n 192.168.20.41 192.168.20.42
+EOF
+test_cleanup rm -rf "${CTDB_BASE}/ctdb.conf"
+
+required_result 0 <<EOF
+192.168.20.41
+192.168.20.42
+EOF
+
+simple_test