From: Roel Kluin Date: Sat, 24 Oct 2009 11:28:45 +0000 (+0200) Subject: hwmon: (fschmd) Fix check on unsigned in watchdog_write() X-Git-Tag: v2.6.31.10~17 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cdbb74a7b9d18c0a3f99c5e242fce12456a52899;p=thirdparty%2Fkernel%2Fstable.git hwmon: (fschmd) Fix check on unsigned in watchdog_write() commit c7702c31340f84cfd5e5df22293578b7ae1e9370 upstream. If unsigned the watchdog_trigger() return value will not be checked correctly. Signed-off-by: Roel Kluin Acked-by: Andrew Morton Cc: Hans de Goede Signed-off-by: Jean Delvare Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/hwmon/fschmd.c b/drivers/hwmon/fschmd.c index ea955edde87e5..37ea6a45d25fc 100644 --- a/drivers/hwmon/fschmd.c +++ b/drivers/hwmon/fschmd.c @@ -819,7 +819,7 @@ static int watchdog_release(struct inode *inode, struct file *filp) static ssize_t watchdog_write(struct file *filp, const char __user *buf, size_t count, loff_t *offset) { - size_t ret; + int ret; struct fschmd_data *data = filp->private_data; if (count) {