From: lpsolit%gmail.com <>
Date: Thu, 28 Jul 2005 04:03:14 +0000 (+0000)
Subject: Bug 302200: uninitialized value when saving email prefs - Patch by Rob Siklos <robzil... 
X-Git-Tag: bugzilla-2.20rc2~19
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cde8a8c0b6d35868aea0f7f0e52e6119d32dcc59;p=thirdparty%2Fbugzilla.git

Bug 302200: uninitialized value when saving email prefs - Patch by Rob Siklos <robzilla@siklos.ca> r=LpSolit a=myk
---

diff --git a/userprefs.cgi b/userprefs.cgi
index 5f52a3ca72..12a05d26f9 100755
--- a/userprefs.cgi
+++ b/userprefs.cgi
@@ -253,7 +253,9 @@ sub SaveEmail {
 
     # Global positive events: a ticked box means "send me mail."
     foreach my $event (GLOBAL_EVENTS) {
-        if (1 == $cgi->param("email-" . REL_ANY . "-$event")) {
+        if (defined($cgi->param("email-" . REL_ANY . "-$event"))
+            && $cgi->param("email-" . REL_ANY . "-$event") == 1)
+        {
             $dbh->do("INSERT INTO email_setting " . 
                      "(user_id, relationship, event) " . 
                      "VALUES ($userid, " . REL_ANY . ", $event)");