From: Ján Tomko <jtomko@redhat.com>
Date: Sun, 2 Aug 2020 21:30:17 +0000 (+0200)
Subject: virsh: completer: use signed variable for XPathNodeSet errors
X-Git-Tag: v6.7.0-rc1~229
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ce2483f6199a2d623f142a992a6afe41015d9ad8;p=thirdparty%2Flibvirt.git

virsh: completer: use signed variable for XPathNodeSet errors

Although virXPathNodeSet is unlikely to return -1, we should
check for it properly or not at all.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/tools/virsh-completer-host.c b/tools/virsh-completer-host.c
index 35e6bba661..8893888ec2 100644
--- a/tools/virsh-completer-host.c
+++ b/tools/virsh-completer-host.c
@@ -55,7 +55,7 @@ virshAllocpagesPagesizeCompleter(vshControl *ctl,
 {
     g_autoptr(xmlXPathContext) ctxt = NULL;
     virshControlPtr priv = ctl->privData;
-    unsigned int npages = 0;
+    int npages = 0;
     g_autofree xmlNodePtr *pages = NULL;
     g_autoptr(xmlDoc) doc = NULL;
     size_t i = 0;
@@ -106,7 +106,7 @@ virshCellnoCompleter(vshControl *ctl,
 {
     g_autoptr(xmlXPathContext) ctxt = NULL;
     virshControlPtr priv = ctl->privData;
-    unsigned int ncells = 0;
+    int ncells = 0;
     g_autofree xmlNodePtr *cells = NULL;
     g_autoptr(xmlDoc) doc = NULL;
     size_t i = 0;