From: Baptiste Daroussin <bapt@FreeBSD.org>
Date: Tue, 20 Jun 2023 08:06:34 +0000 (+0200)
Subject: send_digest: fix double
X-Git-Tag: RELEASE_1_4_0rc1~30
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ce29750de32795235d604ffcd92d13ff82c86c4b;p=thirdparty%2Fmlmmj.git

send_digest: fix double
---

diff --git a/src/send_digest.c b/src/send_digest.c
index a66b97b8..aeab4597 100644
--- a/src/send_digest.c
+++ b/src/send_digest.c
@@ -324,7 +324,6 @@ int send_digest(struct ml *ml, int firstindex, int lastindex,
 		tmp = unistr_utf8_to_header(tmp);
 		xasprintf(&subject, "Subject: %s", tmp);
 		free(tmp);
-		free(line);
 
 		/* Skip the empty line after the subject */
 		line = get_processed_text_line(txt, true, ml);
@@ -334,7 +333,7 @@ int send_digest(struct ml *ml, int firstindex, int lastindex,
 			goto fallback_subject;
 		}
 
-		if (line != NULL) free(line);
+		free(line);
 		line = NULL;
 	} else {
 		log_error(LOG_ARGS, "No subject or invalid "
@@ -415,12 +414,12 @@ errdighdrs:
 			line = get_processed_text_line(txt, false, ml);
 			if (line == NULL) break;
 			if(dprintf(fd, "%s\n", line) < 0) {
-				free(line);
 				log_error(LOG_ARGS, "Could not write"
 						" std mail");
 				break;
 			}
 			free(line);
+			line = NULL;
 		}
 
 		finish_thread_list(tls);