From: Volker Lendecke <vl@samba.org>
Date: Thu, 28 Sep 2023 13:55:36 +0000 (+0200)
Subject: ctdb: Reduce indentation in get_tunable_values()
X-Git-Tag: tevent-0.16.0~213
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ce3243d7b2095970d00e5c59c880ebf81f2bf9ed;p=thirdparty%2Fsamba.git

ctdb: Reduce indentation in get_tunable_values()

Use an early return tvals; review with "git sh -b".

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/ctdb/tests/src/ctdb_takeover_tests.c b/ctdb/tests/src/ctdb_takeover_tests.c
index 19c897b26ff..ad7d7ee9e50 100644
--- a/ctdb/tests/src/ctdb_takeover_tests.c
+++ b/ctdb/tests/src/ctdb_takeover_tests.c
@@ -84,24 +84,27 @@ static uint32_t *get_tunable_values(TALLOC_CTX *tmp_ctx,
 	uint32_t *tvals = talloc_zero_array(tmp_ctx, uint32_t, numnodes);
 	char *t = getenv(tunable);
 
-	if (t) {
-		if (strcmp(t, "1") == 0) {
-			for (i=0; i<numnodes; i++) {
-				tvals[i] = 1;
-			}
-		} else {
-			tok = strtok(t, ",");
-			i = 0;
-			while (tok != NULL) {
-				tvals[i] =
-					(uint32_t) strtol(tok, NULL, 0);
-				i++;
-				tok = strtok(NULL, ",");
-			}
-			if (i != numnodes) {
-				fprintf(stderr, "ERROR: Wrong number of values in %s\n", tunable);
-				exit(1);
-			}
+	if (t == NULL) {
+		return tvals;
+	}
+
+	if (strcmp(t, "1") == 0) {
+		for (i = 0; i < numnodes; i++) {
+			tvals[i] = 1;
+		}
+	} else {
+		tok = strtok(t, ",");
+		i = 0;
+		while (tok != NULL) {
+			tvals[i] = (uint32_t)strtol(tok, NULL, 0);
+			i++;
+			tok = strtok(NULL, ",");
+		}
+		if (i != numnodes) {
+			fprintf(stderr,
+				"ERROR: Wrong number of values in %s\n",
+				tunable);
+			exit(1);
 		}
 	}