From: Evan You Date: Mon, 14 Nov 2022 08:57:44 +0000 (+0800) Subject: chore: fix assertNumber for undefined value X-Git-Tag: v3.2.46~65 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ce363e55a82a82805b370a28cf97329d9394283f;p=thirdparty%2Fvuejs%2Fcore.git chore: fix assertNumber for undefined value --- diff --git a/packages/runtime-core/src/warning.ts b/packages/runtime-core/src/warning.ts index b314985b77..8e93d9efe5 100644 --- a/packages/runtime-core/src/warning.ts +++ b/packages/runtime-core/src/warning.ts @@ -168,7 +168,9 @@ function formatProp(key: string, value: unknown, raw?: boolean): any { */ export function assertNumber(val: unknown, type: string) { if (!__DEV__) return - if (typeof val !== 'number') { + if (val === undefined) { + return + } else if (typeof val !== 'number') { warn(`${type} is not a valid number - ` + `got ${JSON.stringify(val)}.`) } else if (isNaN(val)) { warn(`${type} is NaN - ` + 'the duration expression might be incorrect.') diff --git a/packages/runtime-dom/src/components/Transition.ts b/packages/runtime-dom/src/components/Transition.ts index 205bea9668..a331c53c23 100644 --- a/packages/runtime-dom/src/components/Transition.ts +++ b/packages/runtime-dom/src/components/Transition.ts @@ -283,7 +283,9 @@ function normalizeDuration( function NumberOf(val: unknown): number { const res = toNumber(val) - if (__DEV__) assertNumber(res, ' explicit duration') + if (__DEV__) { + assertNumber(res, ' explicit duration') + } return res }