From: Andrew Bartlett <abartlet@samba.org>
Date: Thu, 14 Oct 2021 19:22:17 +0000 (+1300)
Subject: gitlab-ci: Do not download artifacts of unrelated builds
X-Git-Tag: ldb-2.5.0~395
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ce3d33f4c141afdfa3fbe9fe26835dc32ef95fe0;p=thirdparty%2Fsamba.git

gitlab-ci: Do not download artifacts of unrelated builds

This needs: is overridden in many cases, but ensures none of the other
main jobs start until this build finishes.  However this also
ensures we do not download artifacts from any build unless we
specifically depend on it, saving bandwidth

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14863

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/.gitlab-ci-main.yml b/.gitlab-ci-main.yml
index 6cf2a2de339..f807eef41ce 100644
--- a/.gitlab-ci-main.yml
+++ b/.gitlab-ci-main.yml
@@ -97,6 +97,16 @@ include:
     key: ccache.${CI_JOB_NAME}.${SAMBA_CI_JOB_IMAGE}.${SAMBA_CI_FLAVOR}
     paths:
       - ccache
+
+  # This is overridden in many cases, but ensures none of the other
+  # main jobs start until and unless this build finishes.  However
+  # this also ensures we do not download artifacts from any build
+  # unless we specifically depend on it, saving bandwidth
+
+  needs:
+    - job: samba-def-build
+      artifacts: false
+
   before_script:
     - uname -a
     - lsb_release -a
@@ -176,6 +186,7 @@ others:
 .shared_template_build_only:
   extends: .shared_template
   timeout: 2h
+  needs:
   artifacts:
     expire_in: 1 week
     paths: