From: Jouni Malinen <j@w1.fi>
Date: Mon, 29 Dec 2014 11:05:32 +0000 (+0200)
Subject: Clear wpa_psk memory when setting up wpa_supplicant AP mode
X-Git-Tag: hostap_2_4~622
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ce52d031e5389c81796db863e2cba41b982e1f07;p=thirdparty%2Fhostap.git

Clear wpa_psk memory when setting up wpa_supplicant AP mode

This is more of a theoretical case since this part is done only during
setup and the structure is not allocated in practice. Anyway,
maintaining more consistent use of bin_clear_free() for structures that
may contain keys is useful.

Signed-off-by: Jouni Malinen <j@w1.fi>
---

diff --git a/wpa_supplicant/ap.c b/wpa_supplicant/ap.c
index 64a012017..2ebc7f628 100644
--- a/wpa_supplicant/ap.c
+++ b/wpa_supplicant/ap.c
@@ -225,7 +225,7 @@ static int wpa_supplicant_conf_ap(struct wpa_supplicant *wpa_s,
 	bss->wpa_key_mgmt = ssid->key_mgmt;
 	bss->wpa_pairwise = ssid->pairwise_cipher;
 	if (ssid->psk_set) {
-		os_free(bss->ssid.wpa_psk);
+		bin_clear_free(bss->ssid.wpa_psk, sizeof(*bss->ssid.wpa_psk));
 		bss->ssid.wpa_psk = os_zalloc(sizeof(struct hostapd_wpa_psk));
 		if (bss->ssid.wpa_psk == NULL)
 			return -1;