From: Michal Privoznik <mprivozn@redhat.com>
Date: Mon, 17 Jan 2022 12:20:50 +0000 (+0100)
Subject: virdnsmasq: Drop !caps check from dnsmasqCapsRefreshInternal()
X-Git-Tag: v8.1.0-rc1~404
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ce6bb27649a061a7e83610167ba93c83d98fe337;p=thirdparty%2Flibvirt.git

virdnsmasq: Drop !caps check from dnsmasqCapsRefreshInternal()

There is no way that the dnsmasqCapsRefreshInternal() function
can be called with @caps == NULL. Therefore, drop the if() that
checks for that.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
---

diff --git a/src/util/virdnsmasq.c b/src/util/virdnsmasq.c
index a8fb91ed2b..9f50ce7755 100644
--- a/src/util/virdnsmasq.c
+++ b/src/util/virdnsmasq.c
@@ -653,9 +653,6 @@ dnsmasqCapsRefreshInternal(dnsmasqCaps *caps)
     g_autofree char *version = NULL;
     g_autofree char *complete = NULL;
 
-    if (!caps)
-        return 0;
-
     /* Make sure the binary we are about to try exec'ing exists.
      * Technically we could catch the exec() failure, but that's
      * in a sub-process so it's hard to feed back a useful error.