From: Wolfgang Bumiller <w.bumiller@proxmox.com>
Date: Tue, 29 Oct 2019 07:42:59 +0000 (+0100)
Subject: terminal: return NULL on error in terminal_signal_init
X-Git-Tag: lxc-4.0.0~101^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ce70ff7c4cd43fc23cbddbe4d09c56426a709fc7;p=thirdparty%2Flxc.git

terminal: return NULL on error in terminal_signal_init

Callers expect a NULL on error, and with PR #3171 marking
the pointer as __do_free, we now return a pointer to freed
memory here otherwise.

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
---

diff --git a/src/lxc/terminal.c b/src/lxc/terminal.c
index 13953cf79..126eea475 100644
--- a/src/lxc/terminal.c
+++ b/src/lxc/terminal.c
@@ -174,7 +174,7 @@ on_error:
 		ts->sigfd = -1;
 	}
 
-	return ts;
+	return NULL;
 }
 
 void lxc_terminal_signal_fini(struct lxc_terminal *terminal)