From: Christopher Faulet <cfaulet@haproxy.com>
Date: Fri, 18 Nov 2022 07:44:44 +0000 (+0100)
Subject: CLEANUP: mux-h1: Don't test h1c in h1_shutw_conn()
X-Git-Tag: v2.7-dev9~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ce7928d19c6e9a1b9622dbf79f9e17af71bd2d4b;p=thirdparty%2Fhaproxy.git

CLEANUP: mux-h1: Don't test h1c in h1_shutw_conn()

The H1 connection cannot be NULL when h1_shutw_conn() is called. Thus there
is no reason to test it.

This patch should fix the issue #1936.
---

diff --git a/src/mux_h1.c b/src/mux_h1.c
index 1ab6758acf..9eca08c337 100644
--- a/src/mux_h1.c
+++ b/src/mux_h1.c
@@ -3538,7 +3538,7 @@ static void h1_shutw_conn(struct connection *conn)
 		return;
 
 	conn_xprt_shutw(conn);
-	conn_sock_shutw(conn, (h1c && !(h1c->flags & H1C_F_SILENT_SHUT)));
+	conn_sock_shutw(conn, !(h1c->flags & H1C_F_SILENT_SHUT));
 	TRACE_LEAVE(H1_EV_H1C_END, conn);
 }