From: Tom Christie <tom@tomchristie.com>
Date: Thu, 28 Nov 2024 11:46:59 +0000 (+0000)
Subject: Error on verify as str. (#3418)
X-Git-Tag: 0.28.0~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ce7e14da27abba6574be9b3ea7cd5990556a9343;p=thirdparty%2Fhttpx.git

Error on verify as str. (#3418)
---

diff --git a/httpx/_config.py b/httpx/_config.py
index 9318de3c..1dec1bd3 100644
--- a/httpx/_config.py
+++ b/httpx/_config.py
@@ -31,6 +31,14 @@ def create_ssl_context(verify: ssl.SSLContext | bool = True) -> ssl.SSLContext:
         ssl_context.check_hostname = False
         ssl_context.verify_mode = ssl.CERT_NONE
         return ssl_context
+    elif isinstance(verify, str):  # pragma: nocover
+        # Explicitly handle this deprecated usage pattern.
+        msg = (
+            "verify should be a boolean or SSLContext, since version 0.28. "
+            "Use `verify=ssl.create_default_context(cafile=...)` "
+            "or `verify=ssl.create_default_context(capath=...)`."
+        )
+        raise RuntimeError(msg)
 
     return verify