From: patrickhlauke <redux@splintered.co.uk>
Date: Tue, 31 Oct 2017 13:50:31 +0000 (+0200)
Subject: Add comments to clarify why we ignore a couple of vnu's errors.
X-Git-Tag: v4.0.0-beta.3~138
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ce90b82b19d08673ac529c72e3fe5e6a1c0b607b;p=thirdparty%2Fbootstrap.git

Add comments to clarify why we ignore a couple of vnu's errors.

* "autocomplete" attribute errors
* "legend" is not allowed as child of "div"
---

diff --git a/build/vnu-jar.js b/build/vnu-jar.js
index ea894ac06c..7ac6ed5472 100644
--- a/build/vnu-jar.js
+++ b/build/vnu-jar.js
@@ -22,12 +22,16 @@ childProcess.exec('java -version', (error, stdout, stderr) => {
 
   // vnu-jar accepts multiple ignores joined with a `|`
   const ignores = [
+    // "autocomplete" is included in <button> and checkboxes and radio <input>s due to
+    // Firefox's non-standard autocomplete behavior - see https://bugzilla.mozilla.org/show_bug.cgi?id=654072
     'Attribute “autocomplete” is only allowed when the input type is “color”, “date”, “datetime-local”, “email”, “hidden”, “month”, “number”, “password”, “range”, “search”, “tel”, “text”, “time”, “url”, or “week”.',
     'Attribute “autocomplete” not allowed on element “button” at this point.',
     'Attribute “title” not allowed on element “circle” at this point.',
     'Bad value “tablist” for attribute “role” on element “nav”.',
     // We use holder.js with `data-src` and no `src`; we could work around this, not sure it's worth it.
     'Element “img” is missing required attribute “src”.',
+    // Markup used in Components > Forms > Layout > Form grid > Horizontal form is currently invalid,
+    // but used this way due to lack of support for flexbox layout on <fieldset> element in most browsers
     'Element “legend” not allowed as child of element “div” in this context.*',
     'The “datetime-local” input type is not supported in all browsers. Please be sure to test, and consider using a polyfill.',
     // The next one we are using it because IE11 doesn't recognise <main>.