From: Willy Tarreau <w@1wt.eu>
Date: Mon, 14 Feb 2022 08:26:59 +0000 (+0100)
Subject: CLEANUP: pools: don't needlessly set a call mark during refilling of caches
X-Git-Tag: v2.6-dev2~159
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ceabc5ca8ca8d8919bc95a545b1f2e0aff25ef18;p=thirdparty%2Fhaproxy.git

CLEANUP: pools: don't needlessly set a call mark during refilling of caches

When refilling caches from the shared cache, it's pointless to set the
pointer to the local pool since it may be overwritten immediately after
by the LIST_INSERT(). This is a leftover from the pre-2.4 code in fact.
It didn't hurt, though.
---

diff --git a/src/pool.c b/src/pool.c
index 70a80410d7..0bb79d0253 100644
--- a/src/pool.c
+++ b/src/pool.c
@@ -478,9 +478,6 @@ void pool_refill_local_from_shared(struct pool_head *pool, struct pool_cache_hea
 	count = 0;
 	for (; ret; ret = down) {
 		down = ret->down;
-		/* keep track of where the element was allocated from */
-		POOL_DEBUG_SET_MARK(pool, ret);
-
 		item = (struct pool_cache_item *)ret;
 		POOL_DEBUG_TRACE_CALLER(pool, item, NULL);
 		LIST_INSERT(&pch->list, &item->by_pool);