From: Daniel P. Berrangé <berrange@redhat.com>
Date: Fri, 7 Aug 2020 17:39:22 +0000 (+0100)
Subject: remote: fix error reporting for invalid daemon mode
X-Git-Tag: v6.8.0-rc1~220
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ceabe0f4cc7c656ed64d9b49a646f186f9180e7b;p=thirdparty%2Flibvirt.git

remote: fix error reporting for invalid daemon mode

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 97fff5971a..6e0c04f168 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -872,8 +872,11 @@ doRemoteOpen(virConnectPtr conn,
         goto failed;
 
     if (mode_str &&
-        (mode = remoteDriverModeTypeFromString(mode_str)) < 0)
+        (mode = remoteDriverModeTypeFromString(mode_str)) < 0) {
+        virReportError(VIR_ERR_INVALID_ARG,
+                       _("Unknown remote mode '%s'"), mode_str);
         goto failed;
+    }
 
     if (conf && !proxy_str &&
         virConfGetValueString(conf, "remote_proxy", &proxy_str) < 0)