From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Wed, 27 Dec 2023 23:45:41 +0000 (+1300)
Subject: ldb-samba: matching rules: notify of search failure in transitive filter
X-Git-Tag: tdb-1.4.11~1377
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cebe12bc85a7f178e7ccaecd1c075f2e40478139;p=thirdparty%2Fsamba.git

ldb-samba: matching rules: notify of search failure in transitive filter

It can be very hard to known where transitive checks fail, and this
will help.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15515

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/lib/ldb-samba/ldb_matching_rules.c b/lib/ldb-samba/ldb_matching_rules.c
index 59d1385f4e3..dd1f80628c9 100644
--- a/lib/ldb-samba/ldb_matching_rules.c
+++ b/lib/ldb-samba/ldb_matching_rules.c
@@ -74,6 +74,11 @@ static int ldb_eval_transitive_filter_helper(TALLOC_CTX *mem_ctx,
 			     attrs,
 			     DSDB_MARK_REQ_UNTRUSTED);
 	if (ret != LDB_SUCCESS) {
+		DBG_NOTICE("search failure (%d: %s) looking for '%s' on '%s'\n",
+			   ret,
+			   ldb_strerror(ret),
+			   attr,
+			   ldb_dn_get_linearized(to_visit->dn));
 		talloc_free(tmp_ctx);
 		return ret;
 	}