From: Miod Vallat <miod.vallat@powerdns.com>
Date: Fri, 27 Jun 2025 05:56:36 +0000 (+0200)
Subject: Rework stripDomainSuffix() interface to take a ZoneName. NFC
X-Git-Tag: rec-5.3.0-alpha2~43^2~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cec00a8a3f1dc7268ba5d15e2b3dfeec98a28a90;p=thirdparty%2Fpdns.git

Rework stripDomainSuffix() interface to take a ZoneName. NFC

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---

diff --git a/modules/bindbackend/bindbackend2.cc b/modules/bindbackend/bindbackend2.cc
index b0a54c68c9..102dd395d1 100644
--- a/modules/bindbackend/bindbackend2.cc
+++ b/modules/bindbackend/bindbackend2.cc
@@ -325,8 +325,10 @@ static bool endsOn(const string& domain, const string& suffix)
 }
 
 /** strips a domain suffix from a domain, returns true if it stripped */
-static bool stripDomainSuffix(string* qname, const string& domain)
+static bool stripDomainSuffix(string* qname, const ZoneName& zonename)
 {
+  std::string domain = zonename.operator const DNSName&().toString();
+
   if (!endsOn(*qname, domain)) {
     return false;
   }
@@ -377,7 +379,7 @@ bool Bind2Backend::feedRecord(const DNSResourceRecord& rr, const DNSName& /* ord
   case QType::CNAME:
   case QType::DNAME:
   case QType::NS:
-    stripDomainSuffix(&content, d_transaction_qname.toString());
+    stripDomainSuffix(&content, d_transaction_qname);
     // fallthrough
   default:
     if (d_of && *d_of) {