From: lpsolit%gmail.com <>
Date: Thu, 9 Apr 2009 21:49:04 +0000 (+0000)
Subject: Fix a warning thrown in the web server error log (due to bug 454251)
X-Git-Tag: bugzilla-3.5.1~249
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cec56973dd19c6b949d549d30d4375b76de50e27;p=thirdparty%2Fbugzilla.git

Fix a warning thrown in the web server error log (due to bug 454251)
---

diff --git a/Bugzilla/Attachment.pm b/Bugzilla/Attachment.pm
index 33c761cf15..9748d17f46 100644
--- a/Bugzilla/Attachment.pm
+++ b/Bugzilla/Attachment.pm
@@ -613,12 +613,13 @@ sub _check_filename {
 sub _check_is_private {
     my ($invocant, $is_private) = @_;
 
+    $is_private = $is_private ? 1 : 0;
     if (((!ref $invocant && $is_private)
          || (ref $invocant && $invocant->isprivate != $is_private))
         && !Bugzilla->user->is_insider) {
         ThrowUserError('user_not_insider');
     }
-    return $is_private ? 1 : 0;
+    return $is_private;
 }
 
 sub _check_is_url {