From: sashan <anedvedicky@gmail.com>
Date: Tue, 20 Feb 2018 22:03:36 +0000 (+0100)
Subject: Fix memory leak in KDC PKINIT code
X-Git-Tag: krb5-1.17-beta1~183
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cefc250efd71515dd665b606bcb993e617068758;p=thirdparty%2Fkrb5.git

Fix memory leak in KDC PKINIT code

Commit e5c77a11341a79e6af1e5aef7c587a5b75a9e378 introduced a memory
leak of the client public key in server_process_dh().  Free
client_pubkey on success as well as failure.

ticket: 8644 (new)
target_version: 1.16-next
target_version: 1.15-next
tags: pullup
---

diff --git a/src/plugins/preauth/pkinit/pkinit_crypto_openssl.c b/src/plugins/preauth/pkinit/pkinit_crypto_openssl.c
index ac107c2c1b..0c8dd7e36b 100644
--- a/src/plugins/preauth/pkinit/pkinit_crypto_openssl.c
+++ b/src/plugins/preauth/pkinit/pkinit_crypto_openssl.c
@@ -2979,6 +2979,7 @@ server_process_dh(krb5_context context,
 
     retval = 0;
 
+    BN_free(client_pubkey);
     if (dh_server != NULL)
         DH_free(dh_server);
     return retval;