From: Tim Wiederhake <twiederh@redhat.com>
Date: Mon, 5 Jul 2021 14:55:37 +0000 (+0200)
Subject: virDomainDefValidateAliases: `virHashNew` cannot return NULL
X-Git-Tag: v7.6.0-rc1~47
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cf1234abf1b1d145c19b05ab5c587920afedd560;p=thirdparty%2Flibvirt.git

virDomainDefValidateAliases: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c
index df2ab47361..aab377fbbd 100644
--- a/src/conf/domain_validate.c
+++ b/src/conf/domain_validate.c
@@ -1261,8 +1261,7 @@ virDomainDefValidateAliases(const virDomainDef *def,
     int ret = -1;
 
     /* We are not storing copies of aliases. Don't free them. */
-    if (!(data.aliases = virHashNew(NULL)))
-        goto cleanup;
+    data.aliases = virHashNew(NULL);
 
     if (virDomainDeviceInfoIterateFlags((virDomainDef *) def,
                                         virDomainDeviceDefValidateAliasesIterator,