From: Ruediger Pluem Date: Wed, 26 Sep 2018 09:46:42 +0000 (+0000) Subject: * dav_stream_response processes data that has been allocated from the propdb X-Git-Tag: 2.5.0-alpha2-ci-test-only~2324 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cf26c492a106d667a67a8944bbdc10e0a6fdcbb0;p=thirdparty%2Fapache%2Fhttpd.git * dav_stream_response processes data that has been allocated from the propdb pool. Hence close the propdb *after* dav_stream_response which clears thei probdb pool. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1842010 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/modules/dav/main/mod_dav.c b/modules/dav/main/mod_dav.c index 1f26adb6660..c1619d82e31 100644 --- a/modules/dav/main/mod_dav.c +++ b/modules/dav/main/mod_dav.c @@ -2059,10 +2059,10 @@ static dav_error * dav_propfind_walker(dav_walk_resource *wres, int calltype) : DAV_PROP_INSERT_NAME; propstats = dav_get_allprops(propdb, what); } - dav_close_propdb(propdb); - dav_stream_response(wres, 0, &propstats, ctx->scratchpool); + dav_close_propdb(propdb); + /* at this point, ctx->scratchpool has been used to stream a single response. this function fully controls the pool, and thus has the right to clear it for the next iteration of this