From: Simon McVittie <smcv@collabora.com>
Date: Thu, 12 Apr 2018 12:57:26 +0000 (+0100)
Subject: spec, dbus-daemon(1): Recommend against remote TCP for debugging
X-Git-Tag: dbus-1.13.4~11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cf47380641aac0e5b40694b0ae09ffb85ec4b5fc;p=thirdparty%2Fdbus.git

spec, dbus-daemon(1): Recommend against remote TCP for debugging

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106004
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
Reviewed-by: Philip Withnall <withnall@endlessm.com>
[smcv: Add a TODO comment as suggested]
Signed-off-by: Simon McVittie <smcv@collabora.com>
---

diff --git a/doc/dbus-daemon.1.xml.in b/doc/dbus-daemon.1.xml.in
index b0e0aae05..3761f7e0a 100644
--- a/doc/dbus-daemon.1.xml.in
+++ b/doc/dbus-daemon.1.xml.in
@@ -415,6 +415,16 @@ a transport name plus possible parameters/options.</para>
   configuring the well-known system bus or the well-known session
   bus to listen on a non-loopback TCP address is insecure.
 </para>
+<para>
+  Developers are sometimes tempted to use remote TCP as a debugging
+  tool. However, if this functionality is left enabled in finished
+  products, the result will be dangerously insecure. Instead of
+  using remote TCP, developers should <ulink
+    url="https://lists.freedesktop.org/archives/dbus/2018-April/017447.html"
+    >relay connections via Secure Shell or a similar protocol</ulink>.
+  <!-- TODO: Ideally someone would write a more formal guide to
+       remote D-Bus debugging, and we could link to that instead -->
+</para>
 
 <para>Example: &lt;listen&gt;unix:path=/tmp/foo&lt;/listen&gt;</para>
 
diff --git a/doc/dbus-specification.xml b/doc/dbus-specification.xml
index b60868f5a..6ed317ff6 100644
--- a/doc/dbus-specification.xml
+++ b/doc/dbus-specification.xml
@@ -3730,6 +3730,16 @@
         credentials over a TCP connection, so the EXTERNAL authentication
         mechanism does not work for this transport.
       </para>
+      <para>
+        Developers are sometimes tempted to use remote TCP as a debugging
+        tool. However, if this functionality is left enabled in finished
+        products, the result will be dangerously insecure. Instead of
+        using remote TCP, developers should <ulink
+          url="https://lists.freedesktop.org/archives/dbus/2018-April/017447.html"
+          >relay connections via Secure Shell or a similar protocol</ulink>.
+        <!-- TODO: Ideally someone would write a more formal guide to
+             remote D-Bus debugging, and we could link to that instead -->
+      </para>
       <para>
         All <literal>tcp</literal> addresses are listenable.
         <literal>tcp</literal> addresses in which both