From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 2 Apr 2026 13:41:24 +0000 (+0200)
Subject: qemu: dump: Move 'virCheckFlags' to top level functions
X-Git-Tag: v12.4.0-rc1~106
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cf53aafa7097fc7ff6f187c252cf9e9f6bcf4249;p=thirdparty%2Flibvirt.git

qemu: dump: Move 'virCheckFlags' to top level functions

Move the flag check to the top level to allow programatic introspection
of supported flags.

Extract the supported flags as a macro so that they can be reused in
both coredump APIs.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 38705ef161..6ba2ba5a5e 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -3234,6 +3234,12 @@ doCoreDump(virQEMUDriver *driver,
     return ret;
 }
 
+#define QEMU_DOMAIN_CORE_DUMP_FLAGS \
+    VIR_DUMP_CRASH | \
+    VIR_DUMP_BYPASS_CACHE | \
+    VIR_DUMP_RESET | \
+    VIR_DUMP_MEMORY_ONLY
+
 
 static int
 qemuDomainCoreDumpWithFormat(virDomainPtr dom,
@@ -3248,9 +3254,7 @@ qemuDomainCoreDumpWithFormat(virDomainPtr dom,
     int ret = -1;
     virObjectEvent *event = NULL;
 
-    virCheckFlags(VIR_DUMP_CRASH |
-                  VIR_DUMP_BYPASS_CACHE | VIR_DUMP_RESET |
-                  VIR_DUMP_MEMORY_ONLY, -1);
+    virCheckFlags(QEMU_DOMAIN_CORE_DUMP_FLAGS, -1);
 
     if (!(vm = qemuDomainObjFromDomain(dom)))
         return -1;
@@ -3343,6 +3347,8 @@ qemuDomainCoreDump(virDomainPtr dom,
                    const char *path,
                    unsigned int flags)
 {
+    virCheckFlags(QEMU_DOMAIN_CORE_DUMP_FLAGS, -1);
+
     return qemuDomainCoreDumpWithFormat(dom, path,
                                         VIR_DOMAIN_CORE_DUMP_FORMAT_RAW,
                                         flags);