From: Daniel Veillard <veillard@redhat.com>
Date: Fri, 3 Jul 2015 13:04:24 +0000 (+0800)
Subject: better patch for the XSS search issue
X-Git-Tag: v1.2.18-rc1~146
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cf739b35682305e69a8218731507084535d5e846;p=thirdparty%2Flibvirt.git

better patch for the XSS search issue

Since the query string could be output when displaying the results too
---

diff --git a/docs/search.php.code.in b/docs/search.php.code.in
index 84f87591d5..c7511c3782 100644
--- a/docs/search.php.code.in
+++ b/docs/search.php.code.in
@@ -9,11 +9,12 @@
     $scope = ltrim ($scope);
     if ($scope == "")
         $scope = "any";
+    $querystr = htmlspecialchars($query, ENT_QUOTES, 'UTF-8');
 ?>
 
 <form action="<?php echo $_SERVER['PHP_SELF'], "?query=", rawurlencode($query) ?>"
       enctype="application/x-www-form-urlencoded" method="get">
-  <input name="query" type="text" size="50" value="<?php echo htmlspecialchars($query, ENT_QUOTES, 'UTF-8')?>"/>
+  <input name="query" type="text" size="50" value="<?php echo $querystr ?>"/>
   <select name="scope">
     <option value="any">Search All</option>
     <option value="API" <?php if ($scope == 'API') print "selected='selected'"?>>Only the APIs</option>
@@ -200,7 +201,7 @@
 	    }
 	    mysql_close($link);
 	    $nb = count($results);
-	    echo "<h3 align='center'>Found $nb results for query $query</h3>\n";
+	    echo "<h3 align='center'>Found $nb results for query $querystr</h3>\n";
 	    usort($results, "resSort");
 
             if ($nb > 0) {