From: Alan T. DeKok <aland@freeradius.org>
Date: Tue, 12 Apr 2022 18:48:23 +0000 (-0400)
Subject: try to quiet Coverity.  CID #1469156
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cf7d97195dcafd0b499d06520ee26dc798989bd1;p=thirdparty%2Ffreeradius-server.git

try to quiet Coverity.  CID #1469156
---

diff --git a/scripts/build/dlopen.c b/scripts/build/dlopen.c
index efbc47d6cc2..3e0de25a683 100644
--- a/scripts/build/dlopen.c
+++ b/scripts/build/dlopen.c
@@ -577,16 +577,19 @@ static void ad_have_feature(char const *symbol)
 	ad_define_t *def, **last;
 	size_t len;
 
-	if (!symbol) return;
+	if (!symbol || !*symbol) return;
 
-	len = strlen(symbol);
+	len = strlen(symbol);	
 
-	def = malloc(sizeof(ad_define_t) + len + 5 + 2 + 1);
+	/*
+	 *	"HAVE_" foo "=1\0"
+	 */
+	def = malloc(5 + sizeof(ad_define_t) + len + 2 + 1);
 	if (!def) return;
 
 	memcpy(def->name, "HAVE_", 5);
 	memcpy(def->name + 5, symbol, len);
-	strcpy(def->name + 5 + len, "=1");
+	memcpy(def->name + 5 + len, "=1", 3);
 
 	for (p = def->name + 5; *p != '\0'; p++) {
 		if (islower((int) *p)) {