From: Eric Dumazet <edumazet@google.com>
Date: Wed, 18 Sep 2019 15:05:39 +0000 (-0700)
Subject: sch_netem: fix a divide by zero in tabledist()
X-Git-Tag: v3.16.79~36
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cf83b40c9d22829374811aad99fe26f15a8f70d0;p=thirdparty%2Fkernel%2Fstable.git

sch_netem: fix a divide by zero in tabledist()

commit b41d936b5ecfdb3a4abc525ce6402a6c49cffddc upstream.

syzbot managed to crash the kernel in tabledist() loading
an empty distribution table.

	t = dist->table[rnd % dist->size];

Simply return an error when such load is attempted.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---

diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c
index ab8263d97c5ba..95df63bca9289 100644
--- a/net/sched/sch_netem.c
+++ b/net/sched/sch_netem.c
@@ -737,7 +737,7 @@ static int get_dist_table(struct Qdisc *sch, const struct nlattr *attr)
 	int i;
 	size_t s;
 
-	if (n > NETEM_DIST_MAX)
+	if (!n || n > NETEM_DIST_MAX)
 		return -EINVAL;
 
 	s = sizeof(struct disttable) + n * sizeof(s16);