From: Jonathan Wakely <jwakely@redhat.com>
Date: Fri, 28 Oct 2022 14:28:09 +0000 (+0100)
Subject: libstdc++: Fix dangling reference in filesystem::path::filename()
X-Git-Tag: releases/gcc-10.5.0~171
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cf9eaeaaeec3eb9438b7fc184c493425e8741c88;p=thirdparty%2Fgcc.git

libstdc++: Fix dangling reference in filesystem::path::filename()

The new -Wdangling-reference warning noticed this.

libstdc++-v3/ChangeLog:

	* include/bits/fs_path.h (path::filename()): Fix dangling
	reference.

(cherry picked from commit 49237fe6ef677a81eae701f937546210c90b5914)
---

diff --git a/libstdc++-v3/include/bits/fs_path.h b/libstdc++-v3/include/bits/fs_path.h
index 3370bf7161e0..9f0f2bf5d2dc 100644
--- a/libstdc++-v3/include/bits/fs_path.h
+++ b/libstdc++-v3/include/bits/fs_path.h
@@ -1211,9 +1211,9 @@ namespace __detail
       {
 	if (_M_pathname.back() == preferred_separator)
 	  return {};
-	auto& __last = *--end();
-	if (__last._M_type() == _Type::_Filename)
-	  return __last;
+	auto __last = --end();
+	if (__last->_M_type() == _Type::_Filename)
+	  return *__last;
       }
     return {};
   }