From: Alan T. DeKok <aland@freeradius.org>
Date: Tue, 8 Aug 2017 18:58:22 +0000 (+0200)
Subject: comment out "skip signal" for now
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cfbcb2fae1c72d5307293da94c43ed5cda39b2de;p=thirdparty%2Ffreeradius-server.git

comment out "skip signal" for now

it works in debug mode, as we're single threaded...
in daemon mode, skipping signals when there's no "next" packet
means that it just doesn't respond

We should fix the "skip signal" code to skip the signal only
if the other end hasn't ACKed our last signal.  Because when
it drains the queue, it notices that the last packet wasn't
ACKed, and sends an ACK
---

diff --git a/src/lib/io/channel.c b/src/lib/io/channel.c
index 4748e4fd082..0fac757f52b 100644
--- a/src/lib/io/channel.c
+++ b/src/lib/io/channel.c
@@ -518,7 +518,7 @@ int fr_channel_send_reply(fr_channel_t *ch, fr_channel_data_t *cd, fr_channel_da
 	 *	predictions about packet processing time?
 	 */
 	rad_assert(worker->their_view_of_my_sequence <= worker->sequence);
-#if ENABLE_SKIPS
+#if 0
 	if (((worker->sequence - worker->their_view_of_my_sequence) <= 1000) &&
 	    ((when - worker->last_read_other < SIGNAL_INTERVAL) ||
 	     ((when - worker->last_sent_signal) < SIGNAL_INTERVAL))) {