From: lpsolit%gmail.com <>
Date: Tue, 22 Aug 2006 04:19:09 +0000 (+0000)
Subject: Bug 314501: Use <label>'s on the login form - Patch by Frédéric Buclin <LpSolit@gmail... 
X-Git-Tag: bugzilla-2.23.3~125
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cfbe7958a0559bc20edfa939320646457a35e21b;p=thirdparty%2Fbugzilla.git

Bug 314501: Use <label>'s on the login form - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=myk
---

diff --git a/template/en/default/account/auth/login-small.html.tmpl b/template/en/default/account/auth/login-small.html.tmpl
index 621f65ff04..5a70742f13 100644
--- a/template/en/default/account/auth/login-small.html.tmpl
+++ b/template/en/default/account/auth/login-small.html.tmpl
@@ -36,39 +36,37 @@
 <form name="login" action="[% script_name FILTER html %]" method="POST">
   <table>
     <tr>
-      <td align="right"><b>Login:</b></td>
-      <td><input size="20" name="Bugzilla_login">
+      <th align="right"><label for="Bugzilla_login">Login:</label></th>
+      <td><input size="20" id="Bugzilla_login" name="Bugzilla_login">
           [% Param('emailsuffix') FILTER html %]</td>
     </tr>
     <tr>
-      <td align="right"><b>Password:</b></td>
-      <td><input type="password" size="20" name="Bugzilla_password"></td>
+      <th align="right"><label for="Bugzilla_password">Password:</label></th>
+      <td>
+        <input type="password" size="20" id="Bugzilla_password" name="Bugzilla_password">
+      </td>
     </tr>
 
     [% IF Param('rememberlogin') == 'defaulton' || 
           Param('rememberlogin') == 'defaultoff' %]
       <tr>
-        <td>&nbsp;</td>
+        <th>&nbsp;</th>
         <td>
-          <input type="checkbox" name="Bugzilla_remember" value="on"
+          <input type="checkbox" id="Bugzilla_remember" name="Bugzilla_remember" value="on"
                  [% "checked" IF Param('rememberlogin') == "defaulton" %]>
-          Remember my Login
+          <label for="Bugzilla_remember">Remember my Login</label>
         </td>
       </tr>
     [% END %]
 
     [% IF Param('loginnetmask') < 32 %]
       <tr>
-        <td align="right">
-          <b>
-             Restrict this session<br>
-             to this IP address:
-          </b>
-        </td>
+        <th>&nbsp;</th>
         <td>
-          <input type="checkbox" name="Bugzilla_restrictlogin"
+          <input type="checkbox" id="Bugzilla_restrictlogin" name="Bugzilla_restrictlogin"
                  checked="checked">
-          (Using this option improves security)
+          <label for="Bugzilla_restrictlogin">Restrict this session to this IP address
+          (using this option improves security)</label>
         </td>
       </tr>
     [% END %]
diff --git a/template/en/default/account/auth/login.html.tmpl b/template/en/default/account/auth/login.html.tmpl
index 56d0612d6b..15ec4a477a 100644
--- a/template/en/default/account/auth/login.html.tmpl
+++ b/template/en/default/account/auth/login.html.tmpl
@@ -38,47 +38,39 @@
 <form name="login" action="[% target FILTER html %]" method="POST">
   <table>
     <tr>
-      <td align="right">
-        <b>Login:</b>
-      </td>
+      <th align="right"><label for="Bugzilla_login">Login:</label></th>
       <td>
-        <input size="35" name="Bugzilla_login">
+        <input size="35" id="Bugzilla_login" name="Bugzilla_login">
         [% Param('emailsuffix') FILTER html %]
       </td>
     </tr>
     <tr>
-      <td align="right">
-        <b>Password:</b>
-      </td>
+      <th align="right"><label for="Bugzilla_password">Password:</label></th>
       <td>
-        <input type="password" size="35" name="Bugzilla_password">
+        <input type="password" size="35" id="Bugzilla_password" name="Bugzilla_password">
       </td>
     </tr>
 
     [% IF Param('rememberlogin') == 'defaulton' || 
           Param('rememberlogin') == 'defaultoff' %]
       <tr>
-        <td>&nbsp;</td>
+        <th>&nbsp;</th>
         <td>
-          <input type="checkbox" name="Bugzilla_remember" value="on"
+          <input type="checkbox" id="Bugzilla_remember" name="Bugzilla_remember" value="on"
                  [% "checked" IF Param('rememberlogin') == "defaulton" %]>
-          Remember my Login
+          <label for="Bugzilla_remember">Remember my Login</label>
         </td>
       </tr>
     [% END %]
 
     [% IF Param('loginnetmask') < 32 %]
       <tr>
-        <td align="right">
-          <b>
-             Restrict this session<br>
-             to this IP address:
-          </b>
-        </td>
+        <th>&nbsp;</th>
         <td>
-          <input type="checkbox" name="Bugzilla_restrictlogin"
+          <input type="checkbox" id="Bugzilla_restrictlogin" name="Bugzilla_restrictlogin"
                  checked="checked">
-          (Using this option improves security)
+          <label for="Bugzilla_restrictlogin">Restrict this session to this IP address
+          (using this option improves security)</label>
         </td>
       </tr>
     [% END %]