From: Alan T. DeKok <aland@freeradius.org>
Date: Mon, 4 Apr 2016 15:28:22 +0000 (-0400)
Subject: more messages about broken RADIUS clients
X-Git-Tag: release_3_0_12~167
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cfd9241023191dad05b3ecc5484b6717eb79f065;p=thirdparty%2Ffreeradius-server.git

more messages about broken RADIUS clients
---

diff --git a/src/modules/rlm_eap/mem.c b/src/modules/rlm_eap/mem.c
index 7d9d62cb282..c0899f0c879 100644
--- a/src/modules/rlm_eap/mem.c
+++ b/src/modules/rlm_eap/mem.c
@@ -406,8 +406,14 @@ eap_handler_t *eaplist_find(rlm_eap_t *inst, REQUEST *request,
 	 *	must exist.
 	 */
 	state = fr_pair_find_by_num(request->packet->vps, PW_STATE, 0, TAG_ANY);
-	if (!state ||
-	    (state->vp_length != EAP_STATE_LEN)) {
+	if (!state) {
+		REDEBUG("EAP requires the State attribute to work, but no State exists in the Access-Request packet.");
+		REDEBUG("The RADIUS client is broken.  No amount of changing FreeRADIUS will fix the RADIUS client.");
+		return NULL;
+	}
+
+	if (state->vp_length != EAP_STATE_LEN) {
+		REDEBUG("The RADIUS client has mangled the State attribute, OR you are forcing EAP in the wrong situation");
 		return NULL;
 	}