From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Fri, 13 Jul 2018 02:55:01 +0000 (-0400)
Subject: Correct fastexecutemany test for lower pyodbc version
X-Git-Tag: rel_1_3_0b1~129
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cfe0bfd911fc318c47f52bf8ac3ddb972c5ed86a;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Correct fastexecutemany test for lower pyodbc version

some builds on CI have a pyodbc that is < 4.0.19, make
the check more specific

Change-Id: I69b33c2367d4a03adb00bcf52fb6d1483b0327f8
---

diff --git a/test/requirements.py b/test/requirements.py
index 147b708c83..1d11cea470 100644
--- a/test/requirements.py
+++ b/test/requirements.py
@@ -1083,13 +1083,17 @@ class DefaultRequirements(SuiteRequirements):
         def has_fastexecutemany(config):
             if not against(config, "mssql+pyodbc"):
                 return False
+            if config.db.dialect._dbapi_version() < (4, 0, 19):
+                return False
             with config.db.connect() as conn:
                 drivername = conn.connection.connection.getinfo(
                     config.db.dialect.dbapi.SQL_DRIVER_NAME)
                 # on linux this is 'libmsodbcsql-13.1.so.9.2'.
                 # don't know what it is on windows
                 return "msodbc" in drivername
-        return only_if(has_fastexecutemany)
+        return only_if(
+            has_fastexecutemany,
+            "only on pyodbc > 4.0.19 w/ msodbc driver")
 
     @property
     def python_fixed_issue_8743(self):