From: Peter Krempa <pkrempa@redhat.com>
Date: Fri, 29 Mar 2019 12:48:22 +0000 (+0100)
Subject: util: json: Don't bother logging output string in virJSONValueToString
X-Git-Tag: v5.3.0-rc1~296
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cfe6cecdcac9b8ec65492d26c121d9254b5552b9;p=thirdparty%2Flibvirt.git

util: json: Don't bother logging output string in virJSONValueToString

We have tests that validate the XML formatter. Additionally almost every
guide tells users to disable JSON logging. Drop logging of output string
in virJSONValueToString.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Laine Stump <laine@laine.org>
---

diff --git a/src/util/virjson.c b/src/util/virjson.c
index 7dfc589944..19857d2f2f 100644
--- a/src/util/virjson.c
+++ b/src/util/virjson.c
@@ -2048,16 +2048,11 @@ virJSONValueToString(virJSONValuePtr object,
                      bool pretty)
 {
     VIR_AUTOCLEAN(virBuffer) buf = VIR_BUFFER_INITIALIZER;
-    char *ret = NULL;
 
     if (virJSONValueToBuffer(object, &buf, pretty) < 0)
         return NULL;
 
-    ret = virBufferContentAndReset(&buf);
-
-    VIR_DEBUG("result=%s", NULLSTR(ret));
-
-    return ret;
+    return virBufferContentAndReset(&buf);
 }