From: Tom Peters <thopeter@cisco.com>
Date: Wed, 19 Nov 2014 18:37:31 +0000 (-0500)
Subject: added a couple of FIXIT comments
X-Git-Tag: 3.0.0-233~1189^2~6^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cfee651fd791b4d2b433b1e0a6bc7fc23522f8c0;p=thirdparty%2Fsnort3.git

added a couple of FIXIT comments
---

diff --git a/src/service_inspectors/nhttp_inspect/nhttp_msg_section.cc b/src/service_inspectors/nhttp_inspect/nhttp_msg_section.cc
index b2af8ce75..d1c464c1b 100644
--- a/src/service_inspectors/nhttp_inspect/nhttp_msg_section.cc
+++ b/src/service_inspectors/nhttp_inspect/nhttp_msg_section.cc
@@ -110,6 +110,7 @@ void NHttpMsgSection::legacy_header(bool use_trailer) {
     legacy_cookie(header, source_id);
  }
 
+// FIXIT-M there can be multiple cookie headers in one message.
 void NHttpMsgSection::legacy_cookie(NHttpMsgHeadShared* header, SourceId source_id) {
     HeaderId cookie_head = (source_id == SRC_CLIENT) ? HEAD_COOKIE : HEAD_SET_COOKIE;
 
diff --git a/src/service_inspectors/nhttp_inspect/nhttp_splitter.cc b/src/service_inspectors/nhttp_inspect/nhttp_splitter.cc
index e57bdac46..553f5a803 100644
--- a/src/service_inspectors/nhttp_inspect/nhttp_splitter.cc
+++ b/src/service_inspectors/nhttp_inspect/nhttp_splitter.cc
@@ -85,6 +85,8 @@ ScanResult NHttpHeaderSplitter::split(const uint8_t* buffer, uint32_t length) {
 
     // Header separators: leading \r\n, leading \n, nonleading \r\n\r\n, nonleading \n\r\n, nonleading \r\n\n, and
     // nonleading \n\n. The separator itself becomes num_excess which is discarded during reassemble().
+    // FIXIT-L There is a regression test with a rule that looks for these separators in the header buffer.
+    //         Need to resolve.
     for (uint32_t k = 0; k < length; k++) {
         if (buffer[k] == '\n') {
             num_crlf++;