From: Alan T. DeKok <aland@freeradius.org>
Date: Mon, 23 Jan 2017 19:44:31 +0000 (-0500)
Subject: da may be NULL
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d01c42e2428dbb85a28477c1fdae8027f8a701ce;p=thirdparty%2Ffreeradius-server.git

da may be NULL
---

diff --git a/src/lib/dict.c b/src/lib/dict.c
index 3f66286ffbb..30197168800 100644
--- a/src/lib/dict.c
+++ b/src/lib/dict.c
@@ -3195,7 +3195,14 @@ int fr_dict_unknown_from_oid(fr_dict_t *dict, fr_dict_attr_t *vendor_da, fr_dict
 	/*
 	 *	The common case: Attr-26.  Just create it and go.
 	 */
-	if (!*p) return fr_dict_unknown_from_fields(da, parent, 0, attr);
+	if (!*p) {
+		if (!da) {
+			fr_strerror_printf("Failed creating attribute");
+			return -1;
+		}
+
+		return fr_dict_unknown_from_fields(da, parent, 0, attr);
+	}
 
 	/*
 	 *	Allow only Attr-%d.%d.%d