From: sashan <anedvedicky@gmail.com>
Date: Tue, 20 Feb 2018 21:41:28 +0000 (+0100)
Subject: Fix memory leak in test authdata server
X-Git-Tag: krb5-1.17-beta1~184
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d047fb82738a7c45e71aa5e532621e46d02fa13b;p=thirdparty%2Fkrb5.git

Fix memory leak in test authdata server

greet_kdc_sign() must always free if_relevant.
---

diff --git a/src/plugins/authdata/greet_server/greet_auth.c b/src/plugins/authdata/greet_server/greet_auth.c
index 1f1e9de435..7ef8f666be 100644
--- a/src/plugins/authdata/greet_server/greet_auth.c
+++ b/src/plugins/authdata/greet_server/greet_auth.c
@@ -83,10 +83,9 @@ greet_kdc_sign(krb5_context context,
     if (code == 0) {
         krb5_free_authdata(context, enc_tkt_reply->authorization_data);
         enc_tkt_reply->authorization_data = tkt_authdata;
-    } else {
-        krb5_free_authdata(context, if_relevant);
     }
 
+    krb5_free_authdata(context, if_relevant);
     krb5_free_authdata(context, kdc_issued);
 
     return code;